Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Different scoping for function that has comment in empty parameter list #686

Closed
mjbvz opened this issue Nov 20, 2018 · 4 comments
Closed

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 20, 2018

From microsoft/vscode#63443

TS and JS Grammar Extension version: 0.0.46 / latest

Code

For the code:

({
    a: () => { },
    b: (/**/) => { },
});

a has the scope entity.name.function.ts while b does not. This results in different coloring:

screen shot 2018-11-20 at 2 05 38 pm

@ghost
Copy link

ghost commented Nov 21, 2018

Do you have to install the plugin to be able to use the fix in the future?

@sheetalkamat
Copy link
Member

vscode picks the fixes on regular basis. (not sure about the frequency though)

@mlostekk
Copy link

any idea when this will be published?

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 11, 2019

It's already in VS Code 1.30

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants