-
Notifications
You must be signed in to change notification settings - Fork 12.8k
the '--stripInternal' may cause naming problems. #10165
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
As indicated in the docs, this feature is experimental, and may cause problems. The problems you're describing are why it's not an official feature yet 😉 |
@RyanCavanaugh Thanks for your reply :) The thing is we need this |
2.1 would be the earliest, though I expect it will be later. |
It is great! Thanks for your reply again. @RyanCavanaugh |
I have noticed that lots of guys are waiting for the
internal
modifier : #5228 After a searching, I found this: http://www.typescriptlang.org/docs/handbook/compiler-options.html , and take a look at the option --stripInternal. It's exactly what we need! I just don't know why it is not mentioned in any document. Anyway, thanks for add this awesome feature. we gonna use it in our engine right away.But I think that strip the internal properties or methods away directly may cause some naming problem? For example, if the user creates a subclass and declare a method with the same name to the internal method of the base class. He will not get a error reporting since the internal name is not in the .d.ts file. If I am right, I think the better way to do this is change the modifier to
private
in the .d.ts instead of stripping the internal method away. But for the @internal above the class, I would like to strip it away, otherwise, I have to put lots of @internal in every method within it.The text was updated successfully, but these errors were encountered: