JSDoc support @private and @protected annotations within js files

[que-etc]

TypeScript Version: 2.8.0-dev.20180217

Search Terms:

• jsdoc private
• jsdoc protected

Code

class MyClass {
    /**
     * @private
     */
    privateProperty = 'private';

    /**
     * @protected
     */
    protectedProperty = 'protected';
}

const instance = new MyClass();

instance.privateProperty = 'so-much-for-private';
instance.protectedProperty = 'so-much-for-protected';

Expected behavior:
Following errors should be thrown if --checkJs is enabled:

• When accessing private property: Property 'privateProperty' is private and only accessible within class 'MyClass'.
• When accessing protected property: Property 'protectedProperty' is protected and only accessible within class 'MyClass' and its subclasses.

Actual behavior:
@private and @protected annotations are being ignored.

[que-etc]

It seems that PR #21455 provides support of the @private annotation.

[mhegazy]

Duplicate of #14009

[que-etc]

@mhegazy looks like we got our wires crossed. Issue that you mentioned requires showing private/protected properties in a suggestions list, while this one suggests making former properties behave similar to those defined in .ts files:

class MyClass {
    private privateProp = 'private';
}

const instance = new MyClass();

// In TS files following error is shown:
// "Property 'privateProperty' is private and only accessible within class 'MyClass'"
instance.privateProp = 'new-value'; 

So, I'd expect that in .js files, an attempt to access properties marked with @private access modifier would raise the same error as in .ts files. Of course, only if --checkJs flag is enabled.

[que-etc]

I've just re-read that issue. You are right. Sorry, I wish I had searched better before opening a new ticket.