Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to 24.04.2 for Ubuntu and Ubuntu 24.04 WSL instances #12617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

didrocks
Copy link

We now have 24.04.2 released and hosted on our official ubuntu infrastructure. Point to those WSL images.

We now have 24.04.2 released and hosted on our official ubuntu
infrastructure. Point to those WSL images.
@OneBlue
Copy link
Collaborator

OneBlue commented Feb 21, 2025

Thank you @didrocks. The update looks good.

Looking through the OOBE process, I have two minor suggestions:

  1. In /usr/lib/wsl/wsl-setup:102:

This could use ${WSL_DISTRO_NAME} like this (which should be more reliable than calling wslpath):

echo "Provisioning the new WSL instance ${WSL_DISTRO_NAME}"
  1. In /usr/lib/wsl/wsl-setup:135:

Instead of writing to /etc/wsl.conf, the oobe script could instead add --uid 100 in /usr/lib/wsl/wsl-setup:39 like this:

/usr/sbin/adduser --uid 1000 --quiet --gecos ''  "$username"

Which will automatically work because oobe.defaultUid is already set to 1000 in /etc/wsl-distribution.conf (and WSL keeps track of the default uid outside of the distro itself).

Anyway, those are not blockers at all so let me know if you prefer to merge as-is and potentially fix those in a future release or if you prefer to do another iteration on this PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants