Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Anchor / cross reference is not scrolling to the appropriate section of Notebook #13899

Closed
MsSQLGirl opened this issue Jan 4, 2021 · 5 comments
Assignees
Labels
Milestone

Comments

@MsSQLGirl
Copy link
Contributor

MsSQLGirl commented Jan 4, 2021

  • Azure Data Studio Version:
    Version: 1.26.0-insider (user setup)
    Commit: 30054e6
    Date: 2020-12-30T06:36:16.231Z
    VS Code: 1.48.0
    Electron: 9.3.0
    Chrome: 83.0.4103.122
    Node.js: 12.14.1
    V8: 8.3.110.13-electron.0
    OS: Windows_NT x64 10.0.19042

Steps to Reproduce:

  1. Open https://raw.githubusercontent.com/MsSQLGirl/jubilant-data-wizards/main/Notebook%20Templates/TroubleshootingGuideTemplate.ipynb in ADS.
  2. Try browsing to the notebook parts using the links, i.e.
    image

Expected:
Users should be able to easily see that the page has scrolled to the target heading / anchor.
For example:
When the ADS Window is maximized:

  1. Actual: When users click on "Overview" (because it's visible on the very bottom of the page), users might not realize / easily find where the link goes to. Suggestion: it would be nice to scroll it to the appropriate heading.
  2. Actual: When users click on "Risk / Impacts", "Symptoms" or "Mitigation", the page scrolls but the headings are not visible. i.e. scrolled too much that users might find hard to identify which section is referring to the link clicked.
    AnchorIssueFullScreen

When the ADS Window is in a custom size (i.e. not maximized), the experience is different from when the window is maximized.

  1. Actual: When users click on "Overview" (not visible on the window, it doesn't go anywhere.
  2. Actual: When users click on "Symptoms", the page scrolls but the Symptoms is right in the middle of the window.
    AnchorIssue

I commented a potentially related issue #9941 (comment) - where the offset issue is more severe if the text cell containing the links are somewhere in the middle of a notebook.

File to repro: https://github.com/MsSQLGirl/jubilant-data-wizards/blob/main/Simple%20Demo/Sample%20Notebooks%20-%20Data%20Analysis/ADSNotebooksDemo.ipynb

In Azure Data Studio, you can simply press Ctrl + O, and paste the raw path
https://raw.githubusercontent.com/MsSQLGirl/jubilant-data-wizards/main/Simple%20Demo/Sample%20Notebooks%20-%20Data%20Analysis/ADSNotebooksDemo.ipynb

(in case the below gif doesn't play, click on it)
LinkingIssue

@MsSQLGirl MsSQLGirl added Area - Notebooks Impact: Live site Issues impacting live site work stream labels Jan 4, 2021
@MsSQLGirl
Copy link
Contributor Author

@chlafreniere @halerankin - would you be able to look into this please? Thank you!

@MsSQLGirl MsSQLGirl changed the title Anchor / cross reference is not scrolling to the appropriate parts of Notebook Anchor / cross reference is not scrolling to the appropriate section of Notebook Jan 4, 2021
@halerankin halerankin self-assigned this Jan 4, 2021
@halerankin
Copy link
Contributor

@MsSQLGirl @chlafreniere Just before Christmas, I dedicated an entire day to testing the current experience and to look for possible solutions. So far I have no solutions. I will dive back in.

@corivera corivera added this to the Backlog milestone Jan 11, 2021
@halerankin
Copy link
Contributor

My PR has one approval so far. We should get this into master ASAP.
#13926

@Charles-Gagnon
Copy link
Contributor

@halerankin You should add people as reviewers if you want them to look at it 😄 Many people don't get notified of a PR unless they're added as a reviewer.

@chlafreniere
Copy link
Contributor

Fixed by #13926.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants