html content in columns breaks grid

[tekken22]

Issue Type: Bug

html content in columns breaks grid

SQL Operations Studio version: sqlops 0.31.4 (e026ab8, 2018-07-18T02:14:21.826Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-2623 v4 @ 2.60GHz (8 x 2594)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: unavailable_software webgl: enabled webgl2: enabled
Memory (System)	15.89GB (7.79GB free)
Process Argv	D:\3partyPrograms\micrsosft\sqlops\SQL Operations Studio\sqlops.exe
Screen Reader	no
VM	0%

Extensions: none

[kburtram]

@anthonydresser do you know what's going on here? Did we miss somewhere that we need to add an escape

[kburtram]

@tekken22 do you know the data type of the column that contains the HTML? Is it a string field? If possible, do an example of content that displays like this?

[anthonydresser]

The only character we aren't escaping is ' which shouldn't matter since we don't see that anywhere for it to mess with. Would be interesting to see the content that causes this.

[kburtram]

@tekken22 I published a test build containing #1974 at https://sqlopsbuilds.blob.core.windows.net/stage/sqlops-windows-0.32.1-escape.zip.

That PR contains our best guess at what may be happening here. Please test it out in your scenario if you have a chance.

If that doesn't work we'd like to try to track down what's happening here if possible. We made some accessibility updates in this release that add more extensive aria tags. One issue we've run into in a few places is that the content in the aria string is not properly being escaped for some reason. Unfortunately, without knowing the cell content it's hard to know why the escape method is failing.

When I recently investigated a couple similar issues I used Developer Tools Element Inspector to see why the aria label was messed up. Basically, if you open the Developer Tools and click the arrow in the Elements pane then click the cell element that contains the problematic content, then you can typically see the problem by looking at the aria-label of the cells parent div. This information would be really helpful to root cause this issue.

[tekken22]

this will reproduce, looks like single quote is the issue:

select 'ATTENTION: <span class="param" contenteditable="false">[FirstName]</span>&nbsp; &nbsp;<span class="param" contenteditable="false">[LastName]</span>''s
<span class="param" contenteditable="false">[Type_of_Request]</span>&nbsp;Request 
is submitted' as 'subject'  into #sqlopstest 

select * from #sqlopstest 

[kburtram]

@tekken22 thanks! I verified the repro and confirmed the test build doesn't resolve the problem. We'll work on a fix today.

[kburtram]

@tekken22 the repro scenario is fixed in the latest insiders build at https://github.com/Microsoft/sqlopsstudio/releases/tag/0.32.1 and the fix will be included in the August stable release next month. Thanks for the clear repro script!

Please reactive if you continue to hit this issue.

[kburtram]

It looks like this came back in the August release. We need to get a fix for this today for the recovery build.

[kburtram]

@anthonydresser do you know the best way to resolve this issue? In July we reverted the SlickGrid Accessibility edits, which I'll try to see how that goes. Can we determine which commits to port to the release branch without taking all the SlickGrid changes from master (which contains other regressions).

[anthonydresser]

We could make a special release on slickgrid for this release, but probably just equivalent to just taking an earlier release.

[kburtram]

This should be fixed in https://github.com/Microsoft/sqlopsstudio/releases/tag/0.32.8. Please reactive if the problem persists in the latest build.