Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

port: ResumeDialog is not called after resumption with adaptivedialog (#5426) #1131

Closed
github-actions bot opened this issue Apr 6, 2021 · 0 comments · Fixed by #1140
Closed

port: ResumeDialog is not called after resumption with adaptivedialog (#5426) #1131

github-actions bot opened this issue Apr 6, 2021 · 0 comments · Fixed by #1140
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Milestone
R13

Comments

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

The changes in ResumeDialog is not called after resumption with adaptivedialog (#5426) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5401

Description

  • Updated AdaptiveDialog to store the interruption status in TurnPath.Interrupted so other dialogs can check it and decide if they need to reprompt or continue.
  • Updated InputDialog and SkillDialog to check on interruption status to decide if it is going to reprompt or continue.
  • Update SkillConversationFactory to always return a unique (and different) ID every time CreateSkillConversationIdAsync (this should also address Conversation flow breaks when using more than 1 skill in a dialog botframework-sdk#6248

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Apr 6, 2021
@LeeParrishMSFT LeeParrishMSFT mentioned this issue Apr 7, 2021
Merged
@tracyboehrer tracyboehrer added this to the R13 milestone Apr 8, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
R13
Development

Successfully merging a pull request may close this issue.

Implemented ResumeDialog in Skills microsoft/botbuilder-java
1 participant
@tracyboehrer