Skip to content

Goto Type Definition should probably use range and not just position #1007

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
matklad opened this issue May 30, 2020 · 1 comment
Closed

Comments

@matklad
Copy link
Contributor

matklad commented May 30, 2020

At the moment, goto type definition is specked to use TextDocumentPositionParams:

https://microsoft.github.io/language-server-protocol/specification#textDocument_typeDefinition

I think it is reasonable to use Range, and not just position, for this request. I imagine a user might want to use "extend selection" to select an expression (like foo.bar.baz.foo()), and then "goto type definition" to get to the type of the result.

@dbaeumer
Copy link
Member

Dups #1029

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 26, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants