Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The new "Rename" refactoring destroys the undo stack #1591

Closed
ulrichb opened this issue Sep 19, 2019 · 4 comments
Closed

The new "Rename" refactoring destroys the undo stack #1591

ulrichb opened this issue Sep 19, 2019 · 4 comments

Comments

@ulrichb
Copy link
Contributor

ulrichb commented Sep 19, 2019

monaco-editor version: 0.18.1
Browser: Chrome
OS: Win 10

Steps or JS usage snippet reproducing the issue:

  • Use the following sample (in the playground)
monaco.editor.create(document.getElementById("container"), {
	value: "function hello() {\n\talert('Hello world!');}\n\nhello()\n",
	language: "typescript"
});

=> Expected: Crtl + Z works (and undos the change)

=> Actual: Crtl + Z does nothing

Note: At the moment the rename feature only works in the current model, so IMO there is no reason to destroy the undo stack.

@spahnke
Copy link
Contributor

spahnke commented Sep 19, 2019

I think this is a duplicate of #1548

@ulrichb
Copy link
Contributor Author

ulrichb commented Sep 19, 2019

Ah thanks. => Closing.

@ulrichb ulrichb closed this as completed Sep 19, 2019
@spahnke
Copy link
Contributor

spahnke commented Sep 19, 2019

I edited the other issue to clarify that maybe edit operations of language providers are affected in general.

@ulrichb
Copy link
Contributor Author

ulrichb commented Sep 19, 2019

Cool. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants