Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inspect Editor Tokens - hover stays open #1787

Closed
aeschli opened this issue Jan 28, 2020 · 3 comments · Fixed by microsoft/vscode#90733
Closed

Inspect Editor Tokens - hover stays open #1787

aeschli opened this issue Jan 28, 2020 · 3 comments · Fixed by microsoft/vscode#90733
Labels
editor-hover feature-request Request for new features or functionality
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 28, 2020

Testing microsoft/vscode#89392

Firefox, Shadow Dom

  • Run the Inspect Editor Token command
  • I wasn't able to hide the hover, Escape or setting focus to an element outside the editor didn't work
@aeschli aeschli changed the title Inspect Editor Tokens stays open Inspect Editor Tokens - hover stays open Jan 28, 2020
@alexdima
Copy link
Member

This is unrelate to shadow dom, we simply don't have a way to close that at this time.

@alexdima alexdima added feature-request Request for new features or functionality editor-hover labels Jan 29, 2020
@nrayburn-tech
Copy link
Contributor

@alexdima How exactly would we want to close the hover? Personally, I only want it closed when it gets in the way of the text around what I am looking at. So I would only want it hidden until I click onto the next token. What are your thoughts?
Here is how I have it modified currently. When pressing escape, I set visibility = hidden. On the widget compute, I set the visibility = inherit. (I could also just add another listener, but wasn't really sure if that was necessary.)
CloseHover

@nrayburn-tech
Copy link
Contributor

I just looked in vscode and it has the similar inspect tokens feature, so I think we should setup Monaco the same way.

Escape closes the hover until you select it from the menu again.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
editor-hover feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants