Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Electron 32 #60

Open
johnlindquist opened this issue Aug 23, 2024 · 3 comments
Open

Support Electron 32 #60

johnlindquist opened this issue Aug 23, 2024 · 3 comments

Comments

@johnlindquist
Copy link

johnlindquist commented Aug 23, 2024

I'm getting the same error for node-native-keymap as the sqlite package was getting when attempting upgrade to Electron 32:

/Users/johnlindquist/.electron-gyp/32.0.1/include/node/v8config.h:13:2: error: "C++20 or later required."

WiseLibs/better-sqlite3#1226

I tried forking and solving it myself, but it's just too far out of my wheelhouse to fully understand the problem. Please help :)

Maybe it's related to this?

electron/rebuild#1044

@asamofal
Copy link

Double check that you use v11.2.1 that includes #1226.

v11.2.1 works fine for me now.

@johnlindquist
Copy link
Author

@asamofal yeah, I was implying it's been fixed in SQLite and that this repo might benefit from a similar fix

@asamofal
Copy link

@johnlindquist oh, sorry,I just got the repo confused 🤦‍♂️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants