Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Spawning a terminal won't work correctly with gid = 0. #547

Closed
dejtor opened this issue Jun 29, 2022 · 0 comments · Fixed by #548
Closed

Spawning a terminal won't work correctly with gid = 0. #547

dejtor opened this issue Jun 29, 2022 · 0 comments · Fixed by #548
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
1.0.0

Comments

@dejtor
Copy link

dejtor commented Jun 29, 2022

Environment details

  • OS: MacOs
  • OS version: Monterey 12.2.1
  • node-pty version: 0.10.1

Issue description

Spawning a terminal won't work correctly with gid = 0. It will act as gid is not sent.

node-pty/src/unixTerminal.ts

Line 71 in 1674722

const gid = opt.gid || -1;

@Tyriar Tyriar added this to the 1.0.0 milestone Jun 29, 2022
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2022
@Tyriar Tyriar mentioned this issue Jun 29, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Don't treat uid/gid 0 as undefined microsoft/node-pty
2 participants
@Tyriar @dejtor