-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Bug]: playwright install
is broken when installing 1.51.0
from microsoft conda channel
#2791
Comments
Thanks for filing the issue, looking at the diff (v1.50.0...v1.51.0) its probably caused by #2741. I think we should remove noarch and change
|
@mxschmitt thanks for the prompt reply! That seems like one possible solution, though certainly Wdyt about keeping And apart from the specific fix, does it seem appropriate to possibly:
This way, we can be sure that PRs don't break |
I suppose I should clarify, is the following missing package somehow related to missing
|
FYI: The only reason for os specific conda's is because of Node.js. We have some conda build tests which should probably already yield the problem if we add
If we can easily achieve this, happy to do that but I think better to restore status quo for now. We can potentially follow-up on it. While it sounds good on the first hand it also means that Python/conda is the only language port which doesn't use Playwrights Node.js version. Would have to consult with the team for it first and it probably means we need to add some 'ifs' somewhere in the code to locate it. Do you want to add the test commands and fix it or should I go ahead? I would do it tomorrow then. |
Makes total sense! I've put a PR up for your review here #2792 🙏 |
Version
1.51.0
Steps to reproduce
Example steps
pixi
https://pixi.sh/latest/#installationpixi.toml
manifest file now reads:playwright
python package is importable without error$ pixi run python3 -c "import playwright"
playwright install
is not runnable, throwing:<1.51.0
...$ pixi run playwright install
Expected behavior
I would expect
playwright install
to be runnable without error when installing the latest playwright via themicrosoft
conda channel.Actual behavior
playwright install
is not runnable for the latest release on themicrosoft
conda channel, seemingly due to a lack of packaging thenodejs
dependency.Additional context
One possibility to protect against regressions on the fix might be to include
playwright install
in the test commands here:playwright-python/meta.yaml
Lines 41 to 42 in 256635b
I am happy to contribute a fix if someone can point me in the right direction. TBH, it's a little confusing to me why this might be the case, given that the
meta.yaml
recipe does not seem to have changed too recently.Thank you all for your support, I love working with
playwright
!Environment
The text was updated successfully, but these errors were encountered: