Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change "useLibraryCodeForTypes" = "false" behavior to use inlined types if py.typed is present #1003

Closed
erictraut opened this issue Sep 4, 2020 · 1 comment
Closed

Change "useLibraryCodeForTypes" = "false" behavior to use inlined types if py.typed is present #1003

erictraut opened this issue Sep 4, 2020 · 1 comment
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request

Comments

@erictraut
Copy link
Collaborator

Currently, if the "useLibraryCodeForTypes" setting is "false" (the default for Pyright, but not for Pylance), Pyright will never use ".py" files for type information even if the package is marked as typed via a "py.typed" file. After much discussion, we've decided to change this behavior to be more consistent with the intent behind PEP 561.
@erictraut erictraut added the enhancement request New feature or request label Sep 4, 2020
@erictraut erictraut mentioned this issue Sep 4, 2020
Closed
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Sep 4, 2020
@erictraut
Copy link
Collaborator Author

This is addressed in Pyright 1.1.67, which I just published. It will also be included in next week's release of Pylance.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erictraut