From 66dc9771faaadc2ad3c1377c3d3f632c6737c1be Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Wed, 18 Oct 2023 13:53:48 -0400 Subject: [PATCH] Move winrt/Windows.Storage.h include out of USE_V8 conditional (#12259) * Move winrt/Windows.Storage.h include out of USE_V8 conditional We now use the winrt/Windows.Storage.h header in the initialization of Hermes (not just V8), so this header needs to be imported unconditionally. * Change files --- ...ative-windows-eb48950f-48ba-4e28-b8a9-93a2ce7e2282.json | 7 +++++++ vnext/Microsoft.ReactNative/ReactHost/ReactInstanceWin.cpp | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 change/react-native-windows-eb48950f-48ba-4e28-b8a9-93a2ce7e2282.json diff --git a/change/react-native-windows-eb48950f-48ba-4e28-b8a9-93a2ce7e2282.json b/change/react-native-windows-eb48950f-48ba-4e28-b8a9-93a2ce7e2282.json new file mode 100644 index 00000000000..d3922da489d --- /dev/null +++ b/change/react-native-windows-eb48950f-48ba-4e28-b8a9-93a2ce7e2282.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "Move winrt/Windows.Storage.h include out of USE_V8 conditional", + "packageName": "react-native-windows", + "email": "erozell@outlook.com", + "dependentChangeType": "patch" +} diff --git a/vnext/Microsoft.ReactNative/ReactHost/ReactInstanceWin.cpp b/vnext/Microsoft.ReactNative/ReactHost/ReactInstanceWin.cpp index 8c9ff3479d0..bb0da3810e2 100644 --- a/vnext/Microsoft.ReactNative/ReactHost/ReactInstanceWin.cpp +++ b/vnext/Microsoft.ReactNative/ReactHost/ReactInstanceWin.cpp @@ -74,8 +74,9 @@ #include "BaseScriptStoreImpl.h" #include "HermesRuntimeHolder.h" -#if defined(USE_V8) #include + +#if defined(USE_V8) #include "JSI/V8RuntimeHolder.h" #endif // USE_V8