Move winrt/Windows.Storage.h include out of USE_V8 conditional #12259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use the winrt/Windows.Storage.h header in the initialization of Hermes (not just V8), so this header needs to be imported unconditionally.
acoates-ms
approved these changes
Oct 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
What
We now use the winrt/Windows.Storage.h header in the initialization of Hermes (not just V8), so this header needs to be imported unconditionally.
Changelog
Should this change be included in the release notes: yes
Fixes compilation of Microsoft.ReactNative without USE_V8 compile constant