Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[rush] regression in rush update in 5.128.2 #4947

Open
thomasballinger opened this issue Sep 30, 2024 · 2 comments
Open

[rush] regression in rush update in 5.128.2 #4947

thomasballinger opened this issue Sep 30, 2024 · 2 comments
Assignees

Comments

@thomasballinger
Copy link

In Rush 5.128.2 and beyond (probably from #4752?) the hashes for a project in a rush update never match so the shrinkwrap file always appears out of date.

See Zulip discussion

Summary

rush update doesn't "resolve," every time I run it I get

The shrinkwrap file (pnpm-lock.yaml) contains the following issues:
  Some injected dependencies' package.json might have been modified.

Repro steps

after adding a dependenciesMeta

  "dependenciesMeta": {
    "convex": {
      "injected": true
    }
  },

running rush update twice should not produce

The shrinkwrap file (pnpm-lock.yaml) contains the following issues:
  Some injected dependencies' package.json might have been modified.

this should only happen the first time.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.128.2
rushVersion from rush.json? 5.128.2
useWorkspaces from rush.json? true
Operating system? Mac
Would you consider contributing a PR? No
Node.js version (node -v)? 18.18.0
@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Sep 30, 2024
@iclanton iclanton moved this from Needs triage to High priority in Bug Triage Sep 30, 2024
@lianghx-319
Copy link

same issue when upgrade from 5.128.1 to 5.13x.x

@witcher112
Copy link
Contributor

Potential fix: #4992 (awaiting review at the moment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: High priority
Development

No branches or pull requests

4 participants