Skip to content

MinGW support #136

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
SchrodingerZhu opened this issue Mar 7, 2020 · 4 comments
Closed

MinGW support #136

SchrodingerZhu opened this issue Mar 7, 2020 · 4 comments

Comments

@SchrodingerZhu
Copy link
Collaborator

Currently, the project does not support MinGW.
With the following changes, it can compile with MinGW:

  1. CmakeLists.txt: at about line 74, add a branch AMD64 (quite strange but 'amd64' does not work).
  2. pal_windows.h: add some macros
    #  ifndef _MSC_VER
    #  include <cstdio>
    #  endif
    #  ifndef NOMINMAX
    #  define NOMIXMAX
    #  endif
  3. test/usage.h
    #  ifndef NOMINMAX
    #  define NOMIXMAX
    #  endif

The project compiles but all test fails. Is there any plan to improve the support?

@SchrodingerZhu
Copy link
Collaborator Author

SchrodingerZhu commented Mar 7, 2020

with Release profile, I run into another error:

allostats.h: array subscript 36 is above bounds of 'snmalloc::AllocStats<59, 28>::Stats [28]'

@mjp41
Copy link
Member

mjp41 commented Mar 8, 2020

Thanks for pointing this out. We don't have plans to add support for MinGW, but I am happy to review patches, and take an additional CI process to maintain it.

@SchrodingerZhu
Copy link
Collaborator Author

I think I have made it to work with some small changes. PR will be opened soon.

@SchrodingerZhu
Copy link
Collaborator Author

#137 provides a possible fix

@mjp41 mjp41 closed this as completed Mar 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants