Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move from newtonsoft to System.Text.Json #156

Open
SimonCropp opened this issue Mar 8, 2024 · 2 comments
Open

Move from newtonsoft to System.Text.Json #156

SimonCropp opened this issue Mar 8, 2024 · 2 comments

Comments

@SimonCropp
Copy link

any chance of this happening?

@shueybubbles
Copy link
Collaborator

There are 3 primary consumers of newtonsoft in SMO

  1. The tests. That one is probably easy to change.
  2. The Notebook script writer. That one is probably easy to change. I would also consider removing the Notebook DLL from the regular SMO nuget package into its own package.
  3. The Assessment extensions DLL. That one is less easy to change because the newtonsoft dependency comes from the Assessment package upstream, which we don't own. I would consider removing the Assessment extensions DLL from the SMO package and put it in its own package.

That said, if your SMO application doesn't use the notebook writer or the assessment extensions, you can probably not bother installing newtonsoft with it.

@SimonCropp
Copy link
Author

the problem is that Microsoft.SqlServer.SqlManagementObjects has a dependency on NewtonSoft.Json. so all apps that consume Microsoft.SqlServer.SqlManagementObjects are forced to have NewtonSoft.Json.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants