Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PY] [BF] Run pylint on Python 3.11 #679

Closed
blackchoey opened this issue Oct 16, 2023 · 2 comments · Fixed by microsoft/botbuilder-python#2060
Closed

[PY] [BF] Run pylint on Python 3.11 #679

blackchoey opened this issue Oct 16, 2023 · 2 comments · Fixed by microsoft/botbuilder-python#2060
Assignees
Labels
bot-framework work being tracked that needs to be done in the bot framework SDK large tshirt size large (11-20 days) parity JS → dotnet and/or JS → Python Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label

Comments

@blackchoey
Copy link
Contributor

This is a follow up of microsoft/botbuilder-python#2022

The goal is to update the pipeline to run pylint on Python 3.11 and fix potential new issues on Python 3.11

@blackchoey blackchoey added the Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label label Oct 16, 2023
@blackchoey blackchoey self-assigned this Oct 16, 2023
@blackchoey
Copy link
Contributor Author

PR is ready: microsoft/botbuilder-python#2031
The pylint score on Python 3.11 is same with Python 3.8 on my machine. So there should be no more linting issues on Python 3.11.

The CI does not run because I forked the repo to contribute. Needs help to gain contributor access and pipelines access before we're confident to merge the PR.

@blackchoey
Copy link
Contributor Author

Pylint introduces some new rules along with its release and the CI is now failing because of these rules. There're over 400 new lint issues introduced and many of them requires refactor. So the effort is non-trivial to fix all these issues to pass CI. Needs discussion about how should we define the scope of this task and treat these issues.

Maybe we can start by setting --fail-under parameter to current pylint score. So we can avoid pylint failure for current code base, as well as avoid introducing new lint issues in the future.
Another alternative is to disable the new rules if we think the new rules have lower priority. They already been marked as lower priority by pylint.

@aacebo aacebo added parity JS → dotnet and/or JS → Python bot-framework work being tracked that needs to be done in the bot framework SDK labels Dec 22, 2023
@aacebo aacebo changed the title [botbuilder] Run pylint on Python 3.11 [PY][BB] Run pylint on Python 3.11 Dec 22, 2023
@aacebo aacebo changed the title [PY][BB] Run pylint on Python 3.11 [PY] [BF] Run pylint on Python 3.11 Dec 22, 2023
@aacebo aacebo added the large tshirt size large (11-20 days) label Dec 27, 2023
@aacebo aacebo assigned aacebo and unassigned blackchoey Dec 27, 2023
@aacebo aacebo closed this as completed Jan 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot-framework work being tracked that needs to be done in the bot framework SDK large tshirt size large (11-20 days) parity JS → dotnet and/or JS → Python Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants