Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WPF control / ConPTY example (included) #15053

Open
mitchcapper opened this issue Mar 27, 2023 · 2 comments
Open

WPF control / ConPTY example (included) #15053

mitchcapper opened this issue Mar 27, 2023 · 2 comments
Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Meta The product is the management of the products.
Milestone

Comments

@mitchcapper
Copy link
Contributor

mitchcapper commented Mar 27, 2023

I am aware the ConPTY / wpf control are not yet meant for wide/production use (#6999) . I figured I would put a better example for them working together in a way other users might use it.

From some limited testing it actually works very well.

https://github.com/mitchcapper/ConPtyTermEmulator

Happy to contribute the example here but wasn't quite sure if best to do a PR and if so to where in the repo. There is an airspace issue I don't know if resolvable (some controls allow you to add children to the control itself so those appear on top of the native window.

I think the nuget package may also need restructuring as The ConPTY OpenTerminal.exe did not end up where the native code expected it.

It would be nice if there was a way to get the terminal buffer as well. If there was a select all it would be somewhat hackable with TerminalGetSelection but it doesn't look like it would be too hard to do a PR that is similar to GetSelectedText but for the whole buffer. Let me know if desired.

@mitchcapper mitchcapper added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Mar 27, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 27, 2023
@DHowett
Copy link
Member

DHowett commented Mar 27, 2023

yo, this is so cool!

@carlos-zamora
Copy link
Member

Hi @mitchcapper. Thanks! This is awesome! We're going to hold off on officially* including it as a sample until we've productized ConPTY and the WPF control (i.e. releasing documentation/guidance/etc.).

We love the effort. This demonstrates there's a demand for this and validates us giving support to this. Please continue filing issues for things you encounter. All of this helps with our eventual goal to ship this to consumers.

[*] including this in our repository suggests that we'll be supporting it

@carlos-zamora carlos-zamora added Product-Meta The product is the management of the products. Area-WPFControl Things related to the WPF version of the TermControl and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 29, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Mar 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Meta The product is the management of the products.
Projects
None yet
Development

No branches or pull requests

3 participants