Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The CursorStyle in TerminalTheme does not seem to work #16404

Open
Tracked by #6999
wfjsw opened this issue Dec 1, 2023 · 2 comments
Open
Tracked by #6999

The CursorStyle in TerminalTheme does not seem to work #16404

wfjsw opened this issue Dec 1, 2023 · 2 comments
Labels
Area-WPFControl Things related to the WPF version of the TermControl Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@wfjsw
Copy link

wfjsw commented Dec 1, 2023

Windows Terminal version

be9fc20

Windows build number

10.0.22631.2715

Other Software

No response

Steps to reproduce

https://github.com/microsoft/terminal/blob/main/src/cascadia/WpfTerminalTestNetCore/MainWindow.xaml.cs#L101

Change BlinkingBar to BlinkingBlock

Expected Behavior

No response

Actual Behavior

image

It's still BlinkingBar
@wfjsw wfjsw added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 1, 2023
@wfjsw
Copy link
Author

wfjsw commented Dec 2, 2023

The whole enum does not seems to correspond.
BlinkingBlock => BlinkingUnderline
BlinkingBlockDefault => BlinkingBlock

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-WPFControl Things related to the WPF version of the TermControl labels Dec 6, 2023
@zadjii-msft zadjii-msft mentioned this issue Dec 6, 2023
Open
3 tasks
@zadjii-msft zadjii-msft added this to the Backlog milestone Dec 6, 2023
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Dec 6, 2023
@zadjii-msft
Copy link
Member

That's entirely possible. The WPF control isn't super well supported right now. If you'd like to fix it, please go for it! I'll stick this in #6999. Thanks!

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Area-WPFControl Things related to the WPF version of the TermControl Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@wfjsw @zadjii-msft