Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cmake package config files all wrong #3108

Closed
Fleischner opened this issue Mar 21, 2018 · 4 comments
Closed

Cmake package config files all wrong #3108

Fleischner opened this issue Mar 21, 2018 · 4 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Fleischner
Copy link

Do not allow Package Config Files (*.pc).
They are all wrong! (Assimp, ccd, fcl, flann, freeglut, glew, tinyxml2, and i assume many more)
And indistinguishable between release and debug.

There should be either:

  1. an rule checker to prevent having these files
  2. require them in a certain location and check the content
  3. require them in a certain location and create them with a fixed pattern by vcpkg
@JackBoosY
Copy link
Contributor

JackBoosY commented Apr 28, 2020

Since #9861 merged, the only thing we need to do is to fix these ports.

@Fleischner Could you provide me a list whose ports have this problem?

@JackBoosY
Copy link
Contributor

Related: #6045.

@JonLiu1993
Copy link
Member

@Fleischner ,What are the ports in the latest library that still have these problems? can you give a list

@JackBoosY
Copy link
Contributor

Now I think we can close this issue, since we have vcpkg_fixup_pkgconfig, this issue has been fixed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

4 participants
@Fleischner @JackBoosY @JonLiu1993 and others