Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[libsrt] update to v1.5.4 #43976

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rremilian
Copy link
Contributor

Fixes #43971

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Comment on lines 10 to 11
+ srt_add_application(srt-live-transmit ${VIRTUAL_srtsupport} ${VIRTUAL_srt})
+ target_link_libraries(srt-live-transmit ${SSL_LIBRARIES})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ srt_add_application(srt-live-transmit ${VIRTUAL_srtsupport} ${VIRTUAL_srt})
+ target_link_libraries(srt-live-transmit ${SSL_LIBRARIES})
+ srt_add_application(srt-live-transmit ${VIRTUAL_srtsupport} ${VIRTUAL_srt})
+ target_link_libraries(srt-live-transmit ${SSL_LIBRARIES})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Indent is tab.

Comment on lines 16 to 18
-
+ srt_add_application(srt-file-transmit ${VIRTUAL_srtsupport} ${VIRTUAL_srt})
+ target_link_libraries(srt-file-transmit ${SSL_LIBRARIES})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably keep the original empty line unchanged?

Co-authored-by: Kai Pastor <dg0yt@darc.de>
@JonLiu1993 JonLiu1993 self-assigned this Feb 24, 2025
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 24, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[<libsrt>] update to <1.5.4>
3 participants