From db492b2df0df97c46818276208ca04b9ea74e82b Mon Sep 17 00:00:00 2001 From: Souhit Dey Date: Wed, 24 Feb 2021 00:20:31 +0530 Subject: [PATCH 1/3] add hgroup --- src/data.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data.ts b/src/data.ts index 76e58ee..884aff5 100644 --- a/src/data.ts +++ b/src/data.ts @@ -7,6 +7,6 @@ export const htmlData = { "body", "head", "html", "address", "blockquote", "dd", "div", "section", "article", "aside", "header", "footer", "nav", "menu", "dl", "dt", "fieldset", "form", "frame", "frameset", "h1", "h2", "h3", "h4", "h5", "h6", "iframe", "noframes", "object", "ol", "p", "ul", "applet", "center", "dir", "hr", "pre", "a", "abbr", "acronym", "area", "b", "base", "basefont", "bdo", "big", "br", "button", "caption", "cite", "code", "col", "colgroup", "del", "dfn", "em", "font", "i", "img", "input", "ins", "isindex", "kbd", "label", "legend", "li", "link", "map", "meta", "noscript", "optgroup", "option", "param", "q", "s", "samp", "script", "select", "small", "span", "strike", "strong", "style", "sub", "sup", "table", "tbody", "td", "textarea", "tfoot", "th", "thead", "title", "tr", "tt", "u", "var", - "canvas", "main", "figure", "plaintext", "figcaption" + "canvas", "main", "figure", "plaintext", "figcaption", "hgroup" ] } \ No newline at end of file From bff19c5fac48f37d87fb98888d10055f92032ca2 Mon Sep 17 00:00:00 2001 From: Souhit Dey Date: Wed, 24 Feb 2021 00:24:47 +0530 Subject: [PATCH 2/3] Add test for hgroup --- src/test/expand.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test/expand.test.ts b/src/test/expand.test.ts index e9ee65c..f4f72b1 100644 --- a/src/test/expand.test.ts +++ b/src/test/expand.test.ts @@ -119,6 +119,9 @@ describe('Expand Abbreviations', () => { // https://github.com/microsoft/vscode/issues/114923 testExpandWithCompletion('html', 'figcaption', '
${0}
'); + // https://github.com/microsoft/vscode/issues/117154 + testExpandWithCompletion('html', 'hgroup', '
${0}
'); + // https://github.com/microsoft/vscode/issues/115623 testCountCompletions('html', 'html', 1); testCountCompletions('html', 'body', 1); From 14bee9bfc308c30df7bf07dfd08bbac2c85d1a90 Mon Sep 17 00:00:00 2001 From: Souhit Dey Date: Tue, 2 Mar 2021 08:04:28 +0530 Subject: [PATCH 3/3] Moved the test a bit later in the list --- src/test/expand.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/expand.test.ts b/src/test/expand.test.ts index f4f72b1..11ead93 100644 --- a/src/test/expand.test.ts +++ b/src/test/expand.test.ts @@ -119,9 +119,6 @@ describe('Expand Abbreviations', () => { // https://github.com/microsoft/vscode/issues/114923 testExpandWithCompletion('html', 'figcaption', '
${0}
'); - // https://github.com/microsoft/vscode/issues/117154 - testExpandWithCompletion('html', 'hgroup', '
${0}
'); - // https://github.com/microsoft/vscode/issues/115623 testCountCompletions('html', 'html', 1); testCountCompletions('html', 'body', 1); @@ -146,6 +143,9 @@ describe('Expand Abbreviations', () => { // `output.reverseAttributes` emmet option testExpand('html', 'a.dropdown-item[href=#]{foo}', 'foo', { "output.reverseAttributes": false }); testExpand('html', 'a.dropdown-item[href=#]{foo}', 'foo', { "output.reverseAttributes": true }); + + // https://github.com/microsoft/vscode/issues/117154 + testExpandWithCompletion('html', 'hgroup', '
${0}
'); }); describe('Wrap Abbreviations (basic)', () => {