-
Notifications
You must be signed in to change notification settings - Fork 646
Fork of godef is no longer needed for Go modules support #2194
Comments
Hey, godef-gomod doesn't work any longer in vscode with modules, but godef does. Until https://github.com/Microsoft/vscode-go/blob/master/src/goDeclaration.ts#L83 is updated to remove reference to this tool, I found out that
Makes vscode usable again with Go modules and definitions :) |
VSCode: 1.30.1 godef-gomod install failed:
rename godef.exe to godef-gomod.exe, works fine. |
@ramya-rao-a, I am almost done with PR, however, I am not sure how to display one time notifications. |
@oneslash Do you have a PR open? |
@ramya-rao-a here is it #2234 |
I have merged your PR. I'll take care of the notification in another PR that I am currently reviewing |
Now that the godef fork https://github.com/ianthehat/godef has been merged back to the original repo, we no longer need to use it for Go modules support
godef-gomod
from the list of tools to install/update ingoInstallTools.ts
filegodef
tool. This notification should be shown atmost once in a VS Code session.The text was updated successfully, but these errors were encountered: