go.vetFlags does not support ${workspaceRoot}

[tamayika]

I'm using custom go analyzer using https://godoc.org/golang.org/x/tools/go/analysis and https://godoc.org/golang.org/x/tools/go/analysis/unitchecker.
In command line, I can execute like below.

$ go vet -vettool=`which mytool`

I also want to use mytool in vscode-go extension, but vscode runs go vet in package dir, so I must set absolute path like below.

{
  "go.vetFlags": [
    "-vettool=${workspaceRoot}/bin/mytool"
  ]
}

However "go.vetFlags" does not support ${workspaceRoot}, it remains as is.

I found go.lintFlags support ${workspaceRoot} especially for config flag.

vscode-go/src/goLint.ts

Lines 70 to 85 in af6f7a0

	lintFlags.forEach(flag => {
	// --json is not a valid flag for golint and in gometalinter, it is used to print output in json which we dont want
	if (flag === '--json') {
	return;
	}
	if (flag.startsWith('--config=') || flag.startsWith('-config=')) {
	let configFilePath = flag.substr(flag.indexOf('=') + 1).trim();
	if (!configFilePath) {
	return;
	}
	configFilePath = resolvePath(configFilePath);
	args.push(`${flag.substr(0, flag.indexOf('=') + 1)}${configFilePath}`);
	return;
	}
	args.push(flag);
	});

Is it difficult to support this feature in vscode-go?

[ramya-rao-a]

Its not difficult

You see the support for $workspaceRoot for just the config flag in the lint flags. The same can be done for -vettool as well.

PRs to add this feature are most welcome.
Code Pointers:

• Build and Debug the extension
• goVet.ts is the file to update and

  vscode-go/src/goLint.ts

  Lines 70 to 85 in af6f7a0

  	lintFlags.forEach(flag => {
  	// --json is not a valid flag for golint and in gometalinter, it is used to print output in json which we dont want
  	if (flag === '--json') {
  	return;
  	}
  	if (flag.startsWith('--config=') || flag.startsWith('-config=')) {
  	let configFilePath = flag.substr(flag.indexOf('=') + 1).trim();
  	if (!configFilePath) {
  	return;
  	}
  	configFilePath = resolvePath(configFilePath);
  	args.push(`${flag.substr(0, flag.indexOf('=') + 1)}${configFilePath}`);
  	return;
  	}
  	args.push(flag);
  	});

  can be taken as reference

[tamayika]

thanks for the reply. I'll make a PR

[ramya-rao-a]

Your changes are in the latest beta version of this extension. Can you try it out and confirm that the fix works as expected?

[tamayika]

Thanks for the beta release. I confirmed it works as expected!

[ramya-rao-a]

This feature is now available in the latest update (0.11.0) to the Go extension. Thanks @tamayika!