From b08eaf16ac35c4ed9454f22ee40240e1110ac975 Mon Sep 17 00:00:00 2001 From: alex Date: Sat, 7 Oct 2017 09:56:21 -0400 Subject: [PATCH 1/2] Don't show duplicate errors when go.buildOnSave is set to workspace. Fixes #1228 --- src/goCheck.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/goCheck.ts b/src/goCheck.ts index a6491ee95..41cb24418 100644 --- a/src/goCheck.ts +++ b/src/goCheck.ts @@ -295,5 +295,11 @@ export function check(fileUri: vscode.Uri, goConfig: vscode.WorkspaceConfigurati }); } - return Promise.all(runningToolsPromises).then(resultSets => [].concat.apply([], resultSets)); + return Promise.all(runningToolsPromises).then(function(resultSets){ + let results: ICheckResult[]=[].concat.apply([], resultSets); + // Filter duplicates + return results.filter((results, index, self) => + self.findIndex((t) => { + return t.file === results.file && t.line === results.line && t.msg === results.msg && t.severity == results.severity; }) === index); + }); } From b6d3a74941578638aeafcc9830d568f669687ca4 Mon Sep 17 00:00:00 2001 From: alex Date: Sat, 7 Oct 2017 10:10:07 -0400 Subject: [PATCH 2/2] Lint --- src/goCheck.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/goCheck.ts b/src/goCheck.ts index 41cb24418..62ffe6a0a 100644 --- a/src/goCheck.ts +++ b/src/goCheck.ts @@ -296,10 +296,10 @@ export function check(fileUri: vscode.Uri, goConfig: vscode.WorkspaceConfigurati } return Promise.all(runningToolsPromises).then(function(resultSets){ - let results: ICheckResult[]=[].concat.apply([], resultSets); + let results: ICheckResult[] = [].concat.apply([], resultSets); // Filter duplicates - return results.filter((results, index, self) => + return results.filter((results, index, self) => self.findIndex((t) => { - return t.file === results.file && t.line === results.line && t.msg === results.msg && t.severity == results.severity; }) === index); + return t.file === results.file && t.line === results.line && t.msg === results.msg && t.severity === results.severity; }) === index); }); }