Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

Open
mohankumarelec opened this issue Nov 9, 2024 · 0 comments · May be fixed by #1078
Open

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

mohankumarelec opened this issue Nov 9, 2024 · 0 comments · May be fixed by #1078

Comments

@mohankumarelec
Copy link

The Regex used for checking valid engine version, can have values like 1.96.x, which is not a valid semver.
When using these kinds of version, the semver version comparison fails.

vscode-vsce/src/validation.ts

Lines 51 to 53 in f1fc6d2

if (!/^\*$|^(\^|>=)?((\d+)|x)\.((\d+)|x)\.((\d+)|x)(\-.*)?$/.test(version)) {
throw new Error(`Invalid vscode engine compatibility version '${version}'`);
}

vscode-vsce/src/package.ts

Line 506 in f1fc6d2

if (engineVersion !== 'latest' && !semver.satisfies(engineVersion, '>=1.61', { includePrerelease: true })) {

@mohankumarelec mohankumarelec linked a pull request Nov 9, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the semver comparison mohankumarelec/vscode-vsce
1 participant
@mohankumarelec