HTML figcaption tag should be suggested when using the full word instead of only "figc"

[Youssef1313]

• VSCode Version: 1.52.1 commit ea3859d
• OS Version: Windows 10 1909

Steps to Reproduce:

1. In an html file, write figure and press TAB. You'll see the following behavior, which is correct.

   

   

2. Try the same with figcaption, it doesn't work.

   

3. Try again with only figc, it works.

   

4. The same issue with time tag, but VSCode's Emmet completely doesn't recognize time.

Expected behavior:

The suggestion should show using the full tag figcaption.

[Youssef1313]

cc: @rzhao271

[AnuBhar]

I am starting to look into this issue. Have been able to repro it. figcaption does not have any suggestions, only figc does.

[rzhao271]

@AnuBhar

Code pointer:
https://github.com/microsoft/vscode-emmet-helper/blob/main/src/emmetHelper.ts#L523

We need to add figcaption to commonlyUsedTags. Otherwise the expanded abbreviation gets marked as noise and is thrown out.

[Youssef1313]

@rzhao271 That should go in https://github.com/microsoft/vscode-emmet-helper/blob/main/src/data.ts?
I don't see "figc" there, so confused a little bit how "figc" works today.

[rzhao271]

@Youssef1313 'figc' gets recognized as a snippet here instead
https://github.com/emmetio/emmet/blob/master/snippets/html.json#L110
It's part of markupSnippetKeys rather than commonlyUsedTags.

[rzhao271]

\closedWith 7661c8e