Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test: Align vscode-tslint with the vscode-eslint improvements #12603

Closed
1 task
chrmarti opened this issue Sep 26, 2016 · 0 comments
Closed
1 task

Test: Align vscode-tslint with the vscode-eslint improvements #12603

chrmarti opened this issue Sep 26, 2016 · 0 comments

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Sep 26, 2016

Test for Microsoft/vscode-tslint#86

Complexity - 3

vscode-tslint is now supporting:

  • The status of the TSLint linter is now shown in the status line.
  • Ther tslint.nodePath setting enables to load tslint from a different location than the current workspace or the globally installed npm modules`.
  • Added command to create an initial tslint.json file.

Set up

  • Side install the latest vscode-tslint
    • git clone https://github.com/Microsoft/vscode-tslint
    • cd vscode-tslint
    • Run npm install on both folders "tslint" and "tslint-server"
    • In the "tslint" folder run vsce package -> produces tslint-0.5.40.vsix
    • code-insiders --install-extension tslint-0.5.40.vsix
  • Note that the tslint module has a peer dependency on the typescript module, therefore you must install both tslint and typescript to enable vscode-tslint.

Test

  • Without having tslint and typescript installed try to lint a .ts file. Create a tslint.json file using the command palette.
    • Verify that the status bar item shows an error and the output channel shows the reason.
  • Install tslint and the typescript once locally and globally
    • Verify that you get warnings from tslint
  • Use the setting tslint.nodepath to install tslint and typescript into another location
  • Create an error in the tslint.json file. There are two different error situations:
    • a syntax error in the JSON file, then tslint doesn't attempt to lint
    • a misspelled rule name, this is detect at run-time only
    • Verify that the status item indicates an error in both cases. Clicking the status bar item opens the output channel.
@chrmarti chrmarti added this to the September 2016 milestone Sep 26, 2016
@chrmarti chrmarti assigned ramya-rao-a and unassigned egamma Sep 27, 2016
@ramya-rao-a ramya-rao-a removed their assignment Sep 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants