Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Terminal in Solarized Dark theme seems to have #64912

Closed
totkeks opened this issue Dec 12, 2018 · 2 comments
Closed

Terminal in Solarized Dark theme seems to have #64912

totkeks opened this issue Dec 12, 2018 · 2 comments
Assignees
Labels
terminal General terminal issues that don't fall under another label

Comments

@totkeks
Copy link

totkeks commented Dec 12, 2018

I recently upgraded my PowerShell on Windows to use the Solarized colors as well. For this I found this repository https://github.com/neilpa/cmd-colors-solarized. They also provide a script to show all the current console colors and their mapping to the respective Solarized dark/light colors.

When comparing both I noticed, that the colors in the Powershell terminal inside VS Code where off.
Inside VS code:
image

Regular powershell:
image

Do they both use different mappings of the Solarized colors to the 16 console colors or does the terminal inside VS Code just works entirely differently?

  • VSCode Version: 1.29.1
  • OS Version: Win10 1809

Steps to Reproduce:

  1. Select the Solarized Dark theme for VS Code
  2. Open the terminal with the powershell shell
  3. Run the script Out-Colors.ps1 from https://github.com/neilpa/cmd-colors-solarized
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Dec 12, 2018
@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2018

The VS Code terminal does work a little differently, I'd suggest we hold off on this investigation until conpty ships which should have much more correct colors (see #45693, microsoft/node-pty#216)

@Tyriar Tyriar closed this as completed Dec 12, 2018
@totkeks
Copy link
Author

totkeks commented Dec 12, 2018

Thanks for the quick reply! Your suggestion sounds good. Looking forward to it in future versions.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 26, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

3 participants
@Tyriar @totkeks and others