Go Back/Go Forward: preserve selections

[jrieken]

• in file A select multiple lines
• reveal file B
• invoke Back-command (ctrl+-)
• 🐛 the selection file A is now collapsed/empty

[vscodebot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[bpasero]

Looks like I am doing this on purpose:

vscode/src/vs/workbench/services/history/browser/history.ts

Lines 49 to 52 in c430970

	this.textEditorSelection = Selection.isISelection(_selection) ? {
	startLineNumber: _selection.startLineNumber,
	startColumn: _selection.startColumn
	} : undefined;

This might break people's assumptions if we are going to change it because a user may expect that "Go Back" can be invoked and you can type without deleting whatever was in the selection.

However I should probably revisit using the start line/column and not the end line/column.

[bpasero]

Let's just do it.

Verification: going back/forward restores selections as they were. Note that in order to get a history entry there needs to be at least 10 lines between the positions to consider the entry as new entry.

[ArturoDent]

Works well except with the new Column Selection Mode turned on. Then going back only selects the first line of the previous column selection.

[bpasero]

Yeah, I think the history is currently NOT multi-cursor aware.