Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Required build arguments should not be specified in pipeline YML #5165

Closed
ericstj opened this issue Jul 31, 2024 · 0 comments · Fixed by #5166
Closed

Required build arguments should not be specified in pipeline YML #5165

ericstj opened this issue Jul 31, 2024 · 0 comments · Fixed by #5166

Comments

@ericstj
Copy link
Member

ericstj commented Jul 31, 2024

Description

VSTest requires IncludeSourceRevisionInInformationalVersion to be set to false in order to build successfully with -ci, however this is only specified in the build YML. Instead you should set this in your build targets to avoid folks having to know to set it. This broke the VMR / SourceBuild when the ProductVersion validation was recently added.

Steps to reproduce

See dotnet/sdk#42157 (comment)

Expected behavior

Successful build. No need to specify additional arguments.

Actual behavior

Build fails with

      At D:\a\_work\1\vmr\src\vstest\eng\verify-nupkgs.ps1:292 char:13
      +             throw "$_ contains '+' in the ProductVersion $($_.Version ...
      +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          + CategoryInfo          : OperationStopped: (vstest.console....AAgent in AzDO.:String) [], RuntimeException
          + FullyQualifiedErrorId : vstest.console.dll contains '+' in the ProductVersion 17.12.0-preview-24373-01+e053d5b5b

Diagnostic logs

Binlog: source-inner-build-vstest.zip

Environment

See dotnet/sdk#42157 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant