Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Root level of any tab reset current position #116

Closed
soifou opened this issue Oct 31, 2024 · 3 comments · Fixed by #118
Closed

Root level of any tab reset current position #116

soifou opened this issue Oct 31, 2024 · 3 comments · Fixed by #118
Labels
bug Something isn't working

Comments

@soifou
Copy link
Contributor

soifou commented Oct 31, 2024

Description

I don't know if this is intended but the root level of any tab does not keep the current user position in the list when switching back and forth. Sublevel does (albums of an artist, songs of an album).

The Queue tab behave differently since it will jump to the current playing song, not the first item.

Steps to reproduce

Root level case:

  • Go to Artists tab
  • Select the second one
  • Go to another tab then come back to this tab
  • The first item is selected

Sublevel case:

  • Go to Artists tab
  • Select an artist with several albums
  • Select the second one
  • Go to another tab then come back to this tab
  • The position remains

Expected behavior

I think the expected behaviour would be to always keep the last position in any tab, no matter what level we are.

In the Queue tab, it needs then to have an action to jump to the current song.

What terminal emulator are you running rmpc in?

No response

rmpc debuginfo

no relevant

Config file

no relevant

Relevant log output

no relevant

@soifou soifou added the bug Something isn't working label Oct 31, 2024
@mierak
Copy link
Owner

mierak commented Oct 31, 2024

Yeah I knew about the root level issue and completely forgot. It requires some logic to determine whether its the very first render or not, thanks for reminding me.

For the Queue/Tab pane, fair point, makes more sense to do it as you describe I think.

@mierak
Copy link
Owner

mierak commented Oct 31, 2024

Hopefully solved, the new action is JumpToCurrent in Queue.

Thanks again, you have been a huge help so far!

@mierak mierak closed this as completed Oct 31, 2024
@soifou
Copy link
Contributor Author

soifou commented Nov 1, 2024

Works like a charm :) well done @mierak you rock!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants