Skip to content

Commit

Permalink
update ember-cli and fix linting errors. update AM to 1.1.10
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelcobain committed Nov 22, 2018
1 parent bbb1527 commit 14e3f0f
Show file tree
Hide file tree
Showing 106 changed files with 4,282 additions and 2,689 deletions.
25 changes: 23 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,23 @@
tests/dummy/**/*.js
/blueprints/*/files/**/*.js
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/

# misc
/coverage/
!.*

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try

# snippets
/tests/dummy/snippets/
10 changes: 7 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,21 @@ module.exports = {
],
extends: [
'eslint:recommended',
'plugin:ember/recommended'
'plugin:ember/recommended',
'plugin:ember-suave/recommended'
],
env: {
browser: true
},
rules: {
'ember-suave/require-access-in-comments': 'off',
'ember/closure-actions': 'off'
'ember-suave/require-access-in-comments': 'off'
},
overrides: [
// node files
{
files: [
'.eslintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'index.js',
'testem.js',
Expand All @@ -47,6 +49,8 @@ module.exports = {
plugins: ['node'],
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
// add your custom rules and overrides for node files here
'ember-suave/prefer-destructuring': 'off',
'camelcase': 'off'
})
}
]
Expand Down
23 changes: 14 additions & 9 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,21 +1,26 @@
# See http://help.github.com/ignore-files/ for more about ignoring files.
# See https://help.github.com/ignore-files/ for more about ignoring files.

# compiled output
/dist
/tmp
.idea
/dist/
/tmp/

# dependencies
/node_modules
/bower_components
/bower_components/
/node_modules/

# misc
/.sass-cache
/connect.lock
/coverage/*
/coverage/
/libpeerconnection.log
npm-debug.log*
testem.log
/npm-debug.log*
/testem.log
/yarn-error.log

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try

# editors
/.idea
44 changes: 26 additions & 18 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,21 +1,29 @@
/bower_components
# compiled output
/dist/
/tmp/

# dependencies
/bower_components/

# misc
/.bowerrc
/.editorconfig
/.ember-cli
/.eslintignore
/.eslintrc.js
/.gitignore
/.template-lintrc.js
/.travis.yml
/.watchmanconfig
/bower.json
/config/ember-try.js
/dist
/tests
/tmp
**/.gitkeep
.bowerrc
.editorconfig
.ember-cli
.eslintrc.js
.gitignore
.watchmanconfig
.travis.yml
bower.json
ember-cli-build.js
testem.js
/ember-cli-build.js
/testem.js
/tests/
/yarn.lock
.gitkeep

# ember-try
.node_modules.ember-try/
bower.json.ember-try
package.json.ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
9 changes: 9 additions & 0 deletions .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

module.exports = {
extends: 'recommended',
rules: {
'attribute-indentation': false,
'no-inline-styles': false
}
};
54 changes: 30 additions & 24 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,46 +3,52 @@ language: node_js
node_js:
# we recommend testing addons with the same minimum supported node version as Ember CLI
# so that your addon works for all apps
- "8"
- "6"

sudo: required
sudo: false
dist: trusty

addons:
chrome: stable

cache:
yarn: true
directories:
- $HOME/.npm

env:
global:
# See https://git.io/vdao3 for details.
- JOBS=1
matrix:

jobs:
fail_fast: true
allow_failures:
- env: EMBER_TRY_SCENARIO=ember-canary

include:
# runs linting and tests with current locked deps

- stage: "Tests"
name: "Tests"
script:
- npm run lint:hbs
- npm run lint:js
- npm test

# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-lts-2.12
- EMBER_TRY_SCENARIO=ember-lts-2.16
- EMBER_TRY_SCENARIO=ember-lts-2.18
- EMBER_TRY_SCENARIO=ember-release
- EMBER_TRY_SCENARIO=ember-beta
- EMBER_TRY_SCENARIO=ember-canary
- EMBER_TRY_SCENARIO=ember-default

matrix:
fast_finish: true
allow_failures:
- stage: "Additional Tests"
env: EMBER_TRY_SCENARIO=ember-lts-2.16
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
- env: EMBER_TRY_SCENARIO=ember-release
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-canary
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery

before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH=$HOME/.yarn/bin:$PATH

install:
- yarn install --no-lockfile --non-interactive
- npm config set spin false
- npm install -g npm@4
- npm --version

script:
- yarn lint:js
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO
69 changes: 0 additions & 69 deletions CONTRIBUTING.md

This file was deleted.

8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,15 @@ Navigate through the docs to understand how to use each component.

## Resources

- The team can often be found on the [#e-paper channel on discord](https://discord.gg/zT3asNS). Features and designs are discussed there prior to implementation.
- Contributors can often be found on the [#e-paper channel on discord](https://discord.gg/zT3asNS).

- The [GitHub milestone issue](https://github.com/miguelcobain/ember-paper/issues/249) tracks our progress to version 1.0.

- Building the `ember-paper` demo application will give you your own up-to-date reference. This can be accomplished by installing ember-paper as if it were an application and running `ember server`.

- **Ready to help?** Read our [Contributing Guide](CONTRIBUTING.md).
- Building the `ember-paper` demo application will give you your own up-to-date reference. This can be accomplished by cloning ember-paper as if it were an application and running `ember server`.

## Contributing

This is a very ambitious project. Google's design specs are extensive, and non-trivial to implement. If you can port or fix a component or two, please drop a pull request or issue on GitHub or join us on Discord.
This is an ambitious project. Google's design specs are extensive, and non-trivial to implement. If you can port or fix a component or two, please drop a pull request or issue on GitHub or join us on Discord.

With everyone's help, we can bring this amazing design spec to Ember in a modular and elegant way. The Ember way.

Expand Down
4 changes: 2 additions & 2 deletions addon/components/paper-checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default Component.extend(FocusableMixin, RippleMixin, ColorMixin, Proxiab

click() {
if (!this.get('disabled')) {
invokeAction(this, 'onChange', !this.get('value'))
invokeAction(this, 'onChange', !this.get('value'));
}
// Prevent bubbling, if specified. If undefined, the event will bubble.
return this.get('bubbles');
Expand All @@ -63,6 +63,6 @@ export default Component.extend(FocusableMixin, RippleMixin, ColorMixin, Proxiab
},

processProxy() {
invokeAction(this, 'onChange', !this.get('value'))
invokeAction(this, 'onChange', !this.get('value'));
}
});
3 changes: 1 addition & 2 deletions addon/components/paper-chips.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export default Component.extend({
this.set('autocomplete', autocomplete);
}


// We don't want the autocomplete to open on focus - it'll open when the user starts typing.
if (isPresent(autocomplete)) {
autocomplete.actions.close();
Expand Down Expand Up @@ -113,7 +112,7 @@ export default Component.extend({
},

chipsBlur(event) {
if (!this.focusMovingTo(this.getInput(), event)) {
if (!this.focusMovingTo('.md-chip-input-container input', event)) {
this.set('focusedElement', 'none');
this.set('activeChip', -1);
}
Expand Down
2 changes: 1 addition & 1 deletion addon/components/paper-dialog-inner.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default Component.extend(Translate3dMixin, {
this.checkContentOverflow();
// content overflow might change depending on load of images inside dialog.
let imageElements = this.element.querySelectorAll('img');
this._checkContentOverflowOnLoad = run.bind(this, this.checkContentOverflow)
this._checkContentOverflowOnLoad = run.bind(this, this.checkContentOverflow);
imageElements.forEach((image) => {
image.addEventListener('load', this._checkContentOverflowOnLoad);
});
Expand Down
2 changes: 1 addition & 1 deletion addon/components/paper-dialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default Component.extend({
if (e.keyCode === 27 && this.get('onClose')) {
invokeAction(this, 'onClose');
}
}
};
this._destinationEle.addEventListener('keydown', this._onKeyDown);

}
Expand Down
2 changes: 1 addition & 1 deletion addon/components/paper-grid-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const applyStyles = (el, styles) => {
for (let key in styles) {
el.style[key] = styles[key];
}
}
};

/**
* @class PaperGridList
Expand Down
2 changes: 1 addition & 1 deletion addon/components/paper-grid-tile.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const applyStyles = (el, styles) => {
for (let key in styles) {
el.style[key] = styles[key];
}
}
};

/**
* @class PaperGridTile
Expand Down
Loading

0 comments on commit 14e3f0f

Please # to comment.