Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

paper-progress-circular error while in fastboot #927

Closed
betocantu93 opened this issue May 19, 2018 · 6 comments
Closed

paper-progress-circular error while in fastboot #927

betocantu93 opened this issue May 19, 2018 · 6 comments

Comments

@betocantu93
Copy link
Contributor

Just discovered that this line makes fastboot fail, the easiest way around this is just use the fastboot service for conditional rendering in the template, but I don't know if the component itself should tackle this.

https://github.com/miguelcobain/ember-paper/blob/a45979e6d68b0530cb6eecbe02ad94f4546a8e9a/addon/components/paper-progress-circular.js#L175

@marcgiovannoni
Copy link

Any update on this? Thank you

@betocantu93
Copy link
Contributor Author

This is what I did, and should work

//component.js
 fastboot: service()

//template.hbs
{{#unless fastboot.isFastBoot}}
  {{paper-progress-circular accent=true diameter=40}}
{{//unless}}

@miguelcobain
Copy link
Collaborator

@betocantu93 @marcgiovannoni can any of you test if using the master branch solves this issue?
It should.

@betocantu93
Copy link
Contributor Author

Sorry @miguelcobain forgot the feedback, I tried to replicate my problem and it seems its working with master, thanks...!

@betocantu93
Copy link
Contributor Author

By the way, how do you get the Fastboot global? it's convenient

@miguelcobain
Copy link
Collaborator

@betocantu93 It's just defined on Fastboot environments!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants