Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use splattributes for paper-menu/item #1126

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Use splattributes for paper-menu/item #1126

merged 1 commit into from
Feb 18, 2020

Conversation

boydkr
Copy link
Contributor

@boydkr boydkr commented Feb 14, 2020 •
edited
Loading

paper-menu/item wasn't forwarding ...attributes

Fixes #1125

@boydkr
Copy link
Contributor Author

boydkr commented Feb 14, 2020

failures are in integration tests for paper-chips and paper divider, not sure how this could have caused those

@boydkr boydkr requested a review from miguelcobain February 14, 2020 20:56
@miguelcobain miguelcobain merged commit 70cbb9f into adopted-ember-addons:master Feb 18, 2020
@miguelcobain
Copy link
Collaborator

Thanks. I'll fix the tests separately.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@miguelcobain miguelcobain Awaiting requested review from miguelcobain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

paper-menu item doesn't take attributes
2 participants
@boydkr @miguelcobain