Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix[1134] mouseEnter/Leave/Move deprecations by adding event listeners #1135

Conversation

Shajansheriff
Copy link
Contributor

Fix 1134

@Shajansheriff Shajansheriff force-pushed the fix-mouse-event-deprecation branch 2 times, most recently from ff27f34 to cc42471 Compare March 16, 2020 16:10
@betocantu93
Copy link
Contributor

interesting, I didn't realized you could write native class for mixins!

@Shajansheriff Shajansheriff force-pushed the fix-mouse-event-deprecation branch from cc42471 to 3385132 Compare March 17, 2020 15:36
@Shajansheriff
Copy link
Contributor Author

@betocantu93 We have to replace mixins with native class or with some other patterns. Mixins are going to be removed, however we need to have a roadmap for refactor, because we are using quite a handful of mixins in our addon.

@Shajansheriff Shajansheriff marked this pull request as ready for review March 17, 2020 15:45
@Shajansheriff
Copy link
Contributor Author

@miguelcobain Do you have any idea why those two specific tests are failing? It is passing in my local.

@miguelcobain
Copy link
Collaborator

@Shajansheriff interesting workaround for the deprecation. That didn't cross my mind.
The failing tests are unrelated, as you probably guess.
Those tests are flaky, and I suspect are related to using ember vertical collection. Usually they pass after retrying them some times.
Since it's related I'll merge this even if they don't pass.

@alex9nadon
Copy link
Contributor

@miguelcobain Hi, did you plan to merge and create a new release?

@miguelcobain miguelcobain merged commit 9f7c47a into adopted-ember-addons:master Mar 20, 2020
@Shajansheriff Shajansheriff deleted the fix-mouse-event-deprecation branch March 24, 2020 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting mouseEnter/Leave/Move event handler deprecation logs
4 participants