Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Node.js v14 #28

Closed
jaydenseric opened this issue May 23, 2020 · 1 comment
Closed

Support Node.js v14 #28

jaydenseric opened this issue May 23, 2020 · 1 comment

Comments

@jaydenseric
Copy link
Collaborator

At the moment, the graphql-upload tests are failing for Node.js v14:

https://github.com/jaydenseric/graphql-upload/runs/701487224?check_suite_focus=true#step:4:82

The error is:

_stream_readable.js:636
  throw new ERR_METHOD_NOT_IMPLEMENTED('_read()');
  ^

Error [ERR_METHOD_NOT_IMPLEMENTED]: The _read() method is not implemented
    at Readable._read (_stream_readable.js:636:9)
    at Readable.read (_stream_readable.js:475:10)
    at resume_ (_stream_readable.js:962:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  code: 'ERR_METHOD_NOT_IMPLEMENTED'
}

Is it because of this in fs-capacitor?:

_read(n: number): void {

Does it relate to this Node.js v14 change?:

nodejs/node#31912

Here are the Node.js v14 release notes:

https://nodejs.org/en/blog/release/v14.0.0/

@jaydenseric
Copy link
Collaborator Author

Apologies 🙏

The issue was in the graphql-upload tests:

jaydenseric/graphql-upload@fa758f4

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant