Changed scriptErrorsSuppressed to false

mikevasiloff · web-flow · commit bcf72fa813ee · 2022-03-18T14:14:25.000+01:00
To address bug pnp#1706 in PnP repo so that the pop-up browser authentication window can display the PKI/client certificate selection window.
diff --git a/src/Commands/Utilities/BrowserHelper.cs b/src/Commands/Utilities/BrowserHelper.cs
@@ -24,7 +24,7 @@ internal static class BrowserHelper
         private static ConcurrentDictionary<string, (string requestDigest, DateTime expiresOn)> requestDigestInfos = new ConcurrentDictionary<string, (string requestDigest, DateTime expiresOn)>();
 #pragma warning restore CS0169,CA1823
 
-        internal static ClientContext GetWebLoginClientContext(string siteUrl, bool clearCookies, bool scriptErrorsSuppressed = true, Uri loginRequestUri = null, AzureEnvironment azureEnvironment = AzureEnvironment.Production)
+        internal static ClientContext GetWebLoginClientContext(string siteUrl, bool clearCookies, bool scriptErrorsSuppressed = false, Uri loginRequestUri = null, AzureEnvironment azureEnvironment = AzureEnvironment.Production)
         {
 #if Windows
             if (OperatingSystem.IsWindows())

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ internal static class BrowserHelper`
`24`	`24`	`private static ConcurrentDictionary<string, (string requestDigest, DateTime expiresOn)> requestDigestInfos = new ConcurrentDictionary<string, (string requestDigest, DateTime expiresOn)>();`
`25`	`25`	`#pragma warning restore CS0169,CA1823`
`26`	`26`
`27`		`- internal static ClientContext GetWebLoginClientContext(string siteUrl, bool clearCookies, bool scriptErrorsSuppressed = true, Uri loginRequestUri = null, AzureEnvironment azureEnvironment = AzureEnvironment.Production)`
	`27`	`+ internal static ClientContext GetWebLoginClientContext(string siteUrl, bool clearCookies, bool scriptErrorsSuppressed = false, Uri loginRequestUri = null, AzureEnvironment azureEnvironment = AzureEnvironment.Production)`
`28`	`28`	`{`
`29`	`29`	`#if Windows`
`30`	`30`	`if (OperatingSystem.IsWindows())`