Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for --load-error-handling and --load-media-error-handling #1091

Open
d4rky-pl opened this issue Jan 5, 2024 · 0 comments
Open

Comments

@d4rky-pl
Copy link
Contributor

d4rky-pl commented Jan 5, 2024

Issue description

When generating a PDF that references external assets that then get inlined (for ex. because you rendered the HTML in another part of the application and just pass it to pdf_from_string), if the files fail to load, wkhtmltopdf will not fail by default, causing WickedPDF to generate a broken PDF. This is later hard to detect.

Using raise_on_all_errors: true with log_level: error is unreliable as wkhtmltopdf can output a warning that can be ignored to the STDERR as well (for ex. QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root' is treated as error)

Expected or desired behavior

Right now we can pass --load-error-handling abort --load-media-error-handling abort via extra. It would be great if these were options in WickedPDF config directly

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant