fix: OpenStruct causes NameError in Rake13.2.0 #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
👋 Maybe this is worthy of a version 2.8.1. I run into this issue a few weeks ago upgrading a Rails app from 6.1 to 7.0.8.1 and I ended up adding the This app was already using WickedPdf v2.8.0. And interesting enough: the OpenStruct name error was only happening in Production (not staging, nor CI)... :-D |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #1109
Loading of "ostruct" depends on Rake, so we need to explicitly load it and resolve the dependency.
Because Rake does not load "ostruct" since version 13.2.0.
ruby/rake#545