Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add enable_tokenizer params to VarChar field #36480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengbuqian
Copy link
Collaborator

issue: #35922

add an enable_tokenizer param to varchar field: must be set to true so that a varchar field can enable_match or used as input of BM25 function

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhengbuqian
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Sep 24, 2024
@buqian-zilliz buqian-zilliz force-pushed the add-enable-tokenizer branch 3 times, most recently from cabe0cb to 129289e Compare September 25, 2024 03:14
@mergify mergify bot added the ci-passed label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (a6545b2) to head (7a55818).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/FieldMeta.cpp 0.00% 17 Missing ⚠️
internal/proxy/util.go 25.00% 2 Missing and 1 partial ⚠️
pkg/util/typeutil/field_schema.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36480      +/-   ##
==========================================
- Coverage   82.32%   73.26%   -9.06%     
==========================================
  Files        1281     1286       +5     
  Lines      151551   152144     +593     
==========================================
- Hits       124760   111467   -13293     
- Misses      21763    35630   +13867     
- Partials     5028     5047      +19     
Files with missing lines Coverage Δ
internal/core/src/common/FieldMeta.h 74.57% <100.00%> (-18.65%) ⬇️
internal/core/src/common/Schema.h 91.17% <ø> (-7.36%) ⬇️
internal/util/ctokenizer/text_schema_validator.go 81.81% <100.00%> (+37.37%) ⬆️
pkg/util/typeutil/field_schema.go 89.18% <75.00%> (-3.92%) ⬇️
internal/proxy/util.go 87.46% <25.00%> (-0.13%) ⬇️
internal/core/src/common/FieldMeta.cpp 0.00% <0.00%> (-69.85%) ⬇️

... and 278 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Sep 29, 2024

e2e is not triggered. @zhengbuqian

…o that a varchar field can enable_match or used as input of BM25 function

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Copy link
Contributor

mergify bot commented Sep 30, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dco-passed DCO check passed. kind/feature Issues related to feature request from users size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants