Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

enhance: [2.5] Add management api to check querycoord balance status (#37784) #39909

Merged
merged 1 commit into from
Feb 19, 2025
Merged

enhance: [2.5] Add management api to check querycoord balance status (#37784) #39909

merged 1 commit into from
Feb 19, 2025

Conversation

weiliu1031
Copy link
Contributor

issue: #37783
pr: #37784

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Feb 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 17, 2025
@dosubot dosubot bot added the area/api label Feb 17, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (8c86e4e) to head (b5fe1c7).
Report is 17 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/querycoordv2/ops_services.go 45.45% 10 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39909      +/-   ##
==========================================
+ Coverage   80.96%   81.01%   +0.04%     
==========================================
  Files        1421     1421              
  Lines      201258   201317      +59     
==========================================
+ Hits       162957   163088     +131     
+ Misses      32588    32533      -55     
+ Partials     5713     5696      -17
Components Coverage Δ
Client 79.28% <ø> (ø)
Core 70.06% <ø> (+0.01%) ⬆️
Go 82.94% <79.66%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
internal/distributed/querycoord/client/client.go 95.91% <100.00%> (+0.09%) ⬆️
internal/distributed/querycoord/service.go 80.54% <100.00%> (+0.15%) ⬆️
internal/proxy/management.go 87.44% <100.00%> (+0.75%) ⬆️
internal/util/mock/grpc_querycoord_client.go 94.87% <100.00%> (+0.13%) ⬆️
internal/querycoordv2/ops_services.go 85.75% <45.45%> (-2.70%) ⬇️

... and 30 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031 weiliu1031 changed the title enhance: Add management api to check querycoord balance status (#37784) enhance: [2.5] Add management api to check querycoord balance status (#37784) Feb 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 17, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 19, 2025

/approve
/lgtm

@czs007 czs007 added this to the 2.5.5 milestone Feb 19, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3c2d8c1 into milvus-io:2.5 Feb 19, 2025
19 of 20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved area/api area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
2.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @czs007 @sre-ci-robot