Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance: clean up legacy storage v2 #39987

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

shaoting-huang
Copy link
Contributor

related: #39173

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 19, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 19, 2025
@dosubot dosubot bot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 19, 2025
Copy link
Contributor

mergify bot commented Feb 19, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 19, 2025

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (c917fe4) to head (2e9516d).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39987      +/-   ##
==========================================
+ Coverage   79.76%   80.57%   +0.81%     
==========================================
  Files        1500     1464      -36     
  Lines      207393   205259    -2134     
==========================================
- Hits       165435   165397      -38     
+ Misses      35927    33857    -2070     
+ Partials     6031     6005      -26     
Components Coverage Δ
Client 79.25% <ø> (ø)
Core 69.62% <ø> (ø)
Go 82.42% <ø> (+0.99%) ⬆️

see 37 files with indirect coverage changes

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 19, 2025
@tedxu
Copy link
Contributor

tedxu commented Feb 19, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f47320e into milvus-io:master Feb 19, 2025
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants