Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

node_modules in shared_paths #604

Closed
dddrey opened this issue Feb 20, 2018 · 0 comments
Closed

node_modules in shared_paths #604

dddrey opened this issue Feb 20, 2018 · 0 comments

Comments

@dddrey
Copy link

dddrey commented Feb 20, 2018

Hey, guys.
It's not an issue, I'm just wondering if it's a good practice to put node_modules in shared_paths.
Because i did this thing and my deploy time decreased almost 3 times (from 6.5 mins -≥ to 2.5 mins) and nothing broke or failed.
Logic is that npm doesn't have to install all packages into node_modules directory every time deploying (it costs a lot by the way), only update some packages if necessary (like on local machine).

Steps i did:

cp /path_to_app/current/node_modules /path_to_app/shared
sudo chmod -R 777 /path_to_app/shared/node_modules (maybe not necessary)
add "node_modules" into :shared_paths
mina deploy:link_shared_paths
mina deploy
@dddrey dddrey closed this as completed Mar 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant