Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Message when deleting bundle rules is unclear #5306

Open
eleftherias opened this issue Jan 15, 2025 · 0 comments
Open

Message when deleting bundle rules is unclear #5306

eleftherias opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@eleftherias
Copy link
Contributor

Describe the issue

When Minder is using a bundle and I run minder ruletype delete --all, I see the following:

The following rule type(s) are referenced by existing profiles and were not deleted:
stacklok/actions_check_pinned_tags
stacklok/artifact_attestation_slsa
stacklok/artifact_signature
stacklok/branch_protection_allow_deletions
stacklok/branch_protection_allow_force_pushes
stacklok/branch_protection_allow_fork_syncing
stacklok/branch_protection_enabled
stacklok/branch_protection_enforce_admins
stacklok/branch_protection_lock_branch
stacklok/branch_protection_require_conversation_resolution
stacklok/branch_protection_require_linear_history
stacklok/branch_protection_require_pull_request_approving_review_count
stacklok/branch_protection_require_pull_request_code_owners_review
stacklok/branch_protection_require_pull_request_dismiss_stale_reviews
stacklok/branch_protection_require_pull_request_last_push_approval
stacklok/branch_protection_require_pull_requests
stacklok/branch_protection_require_signatures
stacklok/codeql_enabled
stacklok/dependabot_configured
stacklok/invisible_characters_check
stacklok/license
stacklok/mixed_scripts_check
stacklok/no_binaries_in_repo
stacklok/no_open_security_advisories
stacklok/pr_trusty_check
stacklok/pr_vulnerability_check
stacklok/repo_action_allow_list
stacklok/secret_push_protection
stacklok/secret_scanning
stacklok/trivy_action_enabled

This is correct from the perspective that bundle ruletypes cannot be deleted. However, we should show a better message, for example "The following rule type(s) cannot be deleted because they are part of a the bundle stacklok/healthcheck"

To Reproduce

No response

What version are you using?

No response

@eleftherias eleftherias added bug Something isn't working P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage labels Jan 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Development

No branches or pull requests

1 participant