Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Swap JavaScript minifier from UglifyJS to terser #1140

Closed
colinrotherham opened this issue Feb 5, 2025 · 2 comments · Fixed by #1158
Closed

Swap JavaScript minifier from UglifyJS to terser #1140

colinrotherham opened this issue Feb 5, 2025 · 2 comments · Fixed by #1158
Assignees
@colinrotherham
Labels
maintenance A task that keeps the design system in tip-top shape released

Comments

@colinrotherham
Copy link
Collaborator

What

We should swap the UglifyJS minifier with terser (forked version) as explained on the terser README.md

uglify-es is no longer maintained and uglify-js does not support ES6+.

terser is a fork of uglify-es that mostly retains API and CLI compatibility with uglify-es and uglify-js@3.

Why

This enables minification of ES6+ features

Who needs to be involved

  • Developer

Done

JavaScript is minified using terser and runs without errors
@colinrotherham colinrotherham added the maintenance A task that keeps the design system in tip-top shape label Feb 5, 2025
@colinrotherham
Copy link
Collaborator Author

See alphagov/govuk-frontend#3013

@colinrotherham colinrotherham self-assigned this Feb 5, 2025
@colinrotherham colinrotherham mentioned this issue Feb 12, 2025
Merged
@colinrotherham colinrotherham moved this from In Progress to Blocked in MoJ Design System: Team planning Feb 17, 2025
@colinrotherham colinrotherham linked a pull request Feb 24, 2025 that will close this issue
feat: swap JavaScript minifier from UglifyJS to terser #1158
Merged
@gregtyler
Copy link
Contributor

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@colinrotherham colinrotherham

Labels
maintenance A task that keeps the design system in tip-top shape released
Projects
MoJ Design System: Team planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: swap JavaScript minifier from UglifyJS to terser ministryofjustice/moj-frontend
2 participants
@gregtyler @colinrotherham