Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: migrate to bundled modules using Rollup #1149

Merged
merged 7 commits into from
Feb 25, 2025
Merged

feat: migrate to bundled modules using Rollup #1149

merged 7 commits into from
Feb 25, 2025

Conversation

colinrotherham
Copy link
Collaborator

@colinrotherham colinrotherham commented Feb 6, 2025

This PR updates all component JavaScript with:

  1. CommonJS module.exports in source code
  2. Universal Module Definition (UMD) when packaged

We may need to switch esbuild to Rollup as UMD bundle support isn't included out of the box

Part of #1141

@colinrotherham colinrotherham force-pushed the esbuild branch 2 times, most recently from 083577c to 9bf6147 Compare February 7, 2025 09:23
@colinrotherham colinrotherham marked this pull request as ready for review February 7, 2025 09:24
@colinrotherham colinrotherham requested a review from a team as a code owner February 7, 2025 09:24
@colinrotherham colinrotherham changed the title feat: migrate to bundled modules feat: migrate to bundled modules using Rollup Feb 7, 2025
@colinrotherham colinrotherham changed the base branch from main to linting-post-release February 24, 2025 12:55
Base automatically changed from linting-post-release to main February 24, 2025 19:11
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-esbuild.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

@github-actions github-actions bot added preview:active and removed preview:request Deploy PR to a preview url labels Feb 24, 2025
@colinrotherham colinrotherham merged commit 411e8a3 into main Feb 25, 2025
24 checks passed
@colinrotherham colinrotherham deleted the esbuild branch February 25, 2025 07:49
gregtyler pushed a commit that referenced this pull request Feb 25, 2025
# [3.5.0](v3.4.0...v3.5.0) (2025-02-25)

### Features

* migrate to bundled modules using Rollup ([#1149](#1149)) ([411e8a3](411e8a3))
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JavaScript build to bundle modules (versus concatenation)
3 participants